test: upgrade to different MSCA implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
deleted the
11-18-test_test_upgrading_to_different_MSCA_implementation
branch
howydev
reviewed
Nov 19, 2023
| msca.upgradeToAndCall(mscaImpl2, ""); | ||
|
|
||
| // verify account storage is the same | ||
| (, bytes memory returnData) = address(msca).call(abi.encodeWithSelector(MultiOwnerPlugin.owners.selector)); |
There was a problem hiding this comment.
small nit:
Suggested change
| (, bytes memory returnData) = address(msca).call(abi.encodeWithSelector(MultiOwnerPlugin.owners.selector)); | |
| address[] memory returnedOwners = MultiOwnerPlugin(msca).owners(); |
howydev
reviewed
Nov 19, 2023
|
|
||
| // verify account storage is the same | ||
| (, bytes memory returnData) = address(msca).call(abi.encodeWithSelector(MultiOwnerPlugin.owners.selector)); | ||
| address[] memory returnedOwners = abi.decode(returnData, (address[])); |
There was a problem hiding this comment.
if follow above, remove this line
Suggested change
| address[] memory returnedOwners = abi.decode(returnData, (address[])); |
howydev
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.